Delete obsolete CORINFO_TYPE_... entries by Copilot · Pull Request #128243 · dotnet/runtime

Copilot · 2026-05-15T03:38:15Z

Delete CORINFO_TYPE_STRING, legacy CORINFO_TYPE_REFANY, and CORINFO_TYPE_VAR enum slots from the JIT/EE

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a500bed6-9554-4294-97e7-7aa5d4f2242e Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

This PR updates the CoreCLR JIT/EE CorInfoType contract by removing legacy STRING/REFANY enum entries and reclassifying string as CLASS and typed references as VALUECLASS, with corresponding JIT, VM, interpreter, and SuperPMI cleanup.

Changes:

Remaps CORINFO_TYPE_CLASS and CORINFO_TYPE_VALUECLASS enum values and regenerates the JIT/EE version GUID.
Removes obsolete CORINFO_TYPE_STRING and CORINFO_TYPE_REFANY switch cases across JIT, VM, interpreter, and SuperPMI code.
Adjusts typed-reference handling to flow through value-class paths.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`src/coreclr/inc/corinfo.h`	Updates the canonical `CorInfoType` enum values.
`src/coreclr/inc/jiteeversionguid.h`	Bumps the JIT/EE interface version GUID.
`src/coreclr/vm/jitinterface.cpp`	Maps string to class and typedref to valueclass in VM-to-JIT type conversion.
`src/coreclr/tools/Common/JitInterface/CorInfoTypes.cs`	Mirrors the updated `CorInfoType` enum for managed JIT interface tooling.
`src/coreclr/jit/ee_il_dll.hpp`	Updates CorInfoType-to-var_type lookup tables for the new enum layout.
`src/coreclr/jit/ee_il_dll.cpp`	Removes obsolete refany-specific size assertion.
`src/coreclr/jit/compiler.cpp`	Removes obsolete refany size special case.
`src/coreclr/jit/importer.cpp`	Updates tailcall argument constraint checks for removed refany type.
`src/coreclr/jit/lclvars.cpp`	Removes obsolete refany pointer classification.
`src/coreclr/interpreter/compiler.cpp`	Removes string/refany cases from interpreter type and async return handling.
`src/coreclr/interpreter/naming.cpp`	Removes string/refany cases from interpreter method-name type formatting.
`src/coreclr/tools/superpmi/superpmi-shared/typeutils.cpp`	Updates SuperPMI type utility helpers for removed enum entries.
`src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp`	Updates SuperPMI type string/size helpers.
`src/coreclr/tools/superpmi/mcs/verbildump.cpp`	Removes obsolete string/refany IL-dump cases.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b65149ad-246d-477c-bdc2-c15809e4080f Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

dotnet-policy-service · 2026-05-15T04:45:32Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jkotas · 2026-05-15T04:58:42Z

@copilot Address build breaks:

/__w/1/s/src/mono/browser/emsdk/emscripten/em++ -DBUILDENV_CHECKED=1 -DCOMPILER_SUPPORTS_W_RESERVED_IDENTIFIER -DDEBUG -DDEBUGGING_SUPPORTED -DDISABLE_CONTRACTS -DFEATURE_BASICFREEZE -DFEATURE_COLLECTIBLE_TYPES -DFEATURE_CORECLR -DFEATURE_CORECLR_FLUSH_INSTRUCTION_CACHE_TO_PROTECT_STUB_READS -DFEATURE_DBGIPC_TRANSPORT_DI -DFEATURE_DBGIPC_TRANSPORT_VM -DFEATURE_DEFAULT_INTERFACES -DFEATURE_INTERPRETER -DFEATURE_JAVAMARSHAL -DFEATURE_MULTICOREJIT -DFEATURE_PAL_ANSI -DFEATURE_PORTABLE_ENTRYPOINTS -DFEATURE_PORTABLE_HELPERS -DFEATURE_READYTORUN -DFEATURE_REMOTE_PROC_MEM -DFEATURE_STATICALLY_LINKED -DFEATURE_SYMDIFF -DFEATURE_USE_ASM_GC_WRITE_BARRIERS -DFEATURE_WEBCIL -DHOST_32BIT=1 -DHOST_BROWSER -DHOST_UNIX -DHOST_WASM -DTARGET_32BIT -DTARGET_BROWSER -DTARGET_UNIX -DTARGET_WASM -DTARGET_WASM32 -DUNICODE -DURTBLDENV_FRIENDLY=Checked -D_DBG -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_SECURE_SCL=0 -D_TIME_BITS=64 -D_UNICODE -I/__w/1/s/artifacts/obj/coreclr/browser.wasm.Checked/interpreter -I/__w/1/s/src/coreclr/interpreter -I/__w/1/s/src/native -I/__w/1/s/src/native/inc -I/__w/1/s/src/coreclr/pal/prebuilt/inc -I/__w/1/s/artifacts/obj -I/__w/1/s/src/coreclr/pal/inc -I/__w/1/s/src/coreclr/pal/inc/rt -I/__w/1/s/src/coreclr/pal/src/safecrt -I/__w/1/s/src/coreclr/inc -I/__w/1/s/src/coreclr/debug/inc -I/__w/1/s/src/coreclr/debug/inc/wasm -I/__w/1/s/src/coreclr/debug/inc/dump -I/__w/1/s/src/coreclr/md/inc -I/__w/1/s/artifacts/obj/coreclr/browser.wasm.Checked/inc -I/__w/1/s/src/coreclr/hosts/inc -I/__w/1/s/src/coreclr/interpreter/inc -I/__w/1/s/src/coreclr/minipal -I/__w/1/s/src/coreclr/interpreter/../jitshared -std=gnu++17 -fwasm-exceptions -mbulk-memory -msimd128 -O2 -Wall -Wno-null-conversion -glldb -Wno-unused-parameter -Wno-alloca -Wno-implicit-int-float-conversion -fno-omit-frame-pointer -fno-strict-overflow -fno-strict-aliasing -Werror -Wno-unused-variable -Wno-unused-value -Wno-unused-function -Wno-tautological-compare -Wno-unknown-pragmas -Wimplicit-fallthrough -Wvla -Wno-invalid-offsetof -Wno-unused-but-set-variable -ffp-contract=off -fno-rtti -Wno-unknown-warning-option -ferror-limit=4096 -Wno-unused-private-field -Wno-constant-logical-operand -Wno-pragma-pack -Wno-incompatible-ms-struct -Wno-reserved-identifier -Wno-unsafe-buffer-usage -Wno-single-bit-bitfield-constant-conversion -Wno-cast-function-type-strict -Wno-switch-default -Wno-nontrivial-memaccess -fsigned-char -fvisibility=hidden -ffunction-sections -MD -MT interpreter/CMakeFiles/clrinterpreter_objects.dir/naming.cpp.o -MF interpreter/CMakeFiles/clrinterpreter_objects.dir/naming.cpp.o.d -o interpreter/CMakeFiles/clrinterpreter_objects.dir/naming.cpp.o -c /__w/1/s/src/coreclr/interpreter/naming.cpp
/__w/1/s/src/coreclr/interpreter/naming.cpp:56:9: error: excess elements in array initializer
56 | "typedbyref",

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

jkotas · 2026-05-15T13:22:50Z

-
-        // Generic type variables only appear when we're doing
-        // verification of generic code, in which case we're running
-        // in "import only" mode.  Annoyingly the "import only"


We do not have import only mode in the JIT for verification anymore.

Addressed in e239d06: I removed the obsolete import-only/verification comment block in ee_il_dll.hpp along with the CORINFO_TYPE_VAR mapping cleanup.

jkotas · 2026-05-16T18:44:50Z

@copilot Merge from main and resolve conflicts

jkotas · 2026-05-16T18:54:05Z

    {
        sigSize = info.compCompHnd->getClassSize(clsHnd);
    }
-    else if (cit == CORINFO_TYPE_REFANY)


The JIT handles TypedReference as a regular byref-like type. We do not need to special case it in the CORINFO_TYPE_... enum.

…o-types # Conflicts: # src/coreclr/inc/jiteeversionguid.h Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-16T19:16:56Z

@copilot Merge from main and resolve conflicts

Merged latest main and resolved the conflict in jiteeversionguid.h by generating a new JIT/EE GUID in 5ca9b86.

jkotas · 2026-05-16T19:30:21Z

@EgorBo PTLA. JIT/EE interface cleanup.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

Remove CORINFO_TYPE_STRING and merge REFANY into VALUECLASS

a380468

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a500bed6-9554-4294-97e7-7aa5d4f2242e Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI assigned Copilot and jkotas May 15, 2026

Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 03:38

Copilot created this pull request from a session on behalf of jkotas May 15, 2026 03:38 View session

Copilot finished work on behalf of jkotas May 15, 2026 03:38

Copilot AI requested a review from jkotas May 15, 2026 03:38

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Copilot started work on behalf of jkotas May 15, 2026 03:51 View session

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/interpreter/compiler.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/interpreter/compiler.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/compiler.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/ee_il_dll.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/ee_il_dll.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/importer.cpp Outdated

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/lclvars.cpp Outdated

Apply suggestions from code review

e5abd7a

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot AI review requested due to automatic review settings May 15, 2026 03:56

Copilot started reviewing on behalf of jkotas May 15, 2026 03:56 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Comment thread src/coreclr/interpreter/compiler.cpp

Comment thread src/coreclr/tools/superpmi/mcs/verbildump.cpp

Renumber CorInfoType members sequentially per review feedback

b8468c1

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b65149ad-246d-477c-bdc2-c15809e4080f Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI changed the title ~~Delete CORINFO_TYPE_STRING and legacy CORINFO_TYPE_VALUECLASS entries~~ Delete CORINFO_TYPE_STRING and legacy CORINFO_TYPE_VALUECLASS entries; renumber CorInfoType sequentially May 15, 2026

Copilot finished work on behalf of jkotas May 15, 2026 04:16

Copilot AI requested a review from jkotas May 15, 2026 04:16

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Copilot started work on behalf of jkotas May 15, 2026 04:28 View session

github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 15, 2026

jkotas requested review from BrzVlad, MichalStrehovsky, janvorli and kg as code owners May 15, 2026 13:14

Copilot started reviewing on behalf of jkotas May 15, 2026 13:15 View session

jkotas reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp Outdated

Comment thread src/coreclr/vm/jitinterface.cpp Outdated

Apply suggestions from code review

9931686

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread src/coreclr/jit/lclvars.cpp

Comment thread src/coreclr/interpreter/compiler.cpp

jkotas reviewed May 15, 2026

View reviewed changes

jkotas changed the title ~~Delete CORINFO_TYPE_STRING, legacy CORINFO_TYPE_REFANY, and CORINFO_TYPE_VAR entries; renumber CorInfoType sequentially~~ Delete obsolete CORINFO_TYPE_... entries May 15, 2026

Merge branch 'main' into copilot/delete-corinfo-types

7876f07

build-analysis Bot mentioned this pull request May 16, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

Copilot started work on behalf of jkotas May 16, 2026 18:45 View session

jkotas reviewed May 16, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into copilot/delete-corinf…

5ca9b86

…o-types # Conflicts: # src/coreclr/inc/jiteeversionguid.h Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 16, 2026 19:16

Copilot finished work on behalf of jkotas May 16, 2026 19:17

Copilot AI requested a review from jkotas May 16, 2026 19:17

jkotas reviewed May 16, 2026

View reviewed changes

Comment thread src/coreclr/jit/ee_il_dll.hpp Outdated

Apply suggestion from @jkotas

bc8bcf6

Copilot AI review requested due to automatic review settings May 16, 2026 19:28

Copilot started reviewing on behalf of jkotas May 16, 2026 19:28 View session

jkotas requested a review from EgorBo May 16, 2026 19:30

Copilot AI reviewed May 16, 2026

View reviewed changes

build-analysis Bot mentioned this pull request May 17, 2026

Assertion failed: new_time >= loop->time in Component Governance Detection dotnet/dnceng#6510

Open

3 tasks

elinor-fung mentioned this pull request May 17, 2026

[wasm] Tests failing with DirectoryNotFoundException trying to load test data #128293

Open

Conversation

Copilot AI commented May 15, 2026 • edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 15, 2026

Uh oh!

jkotas commented May 15, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jkotas May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 16, 2026

Choose a reason for hiding this comment

Uh oh!

jkotas commented May 16, 2026

Uh oh!

jkotas May 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

Uh oh!

jkotas commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 15, 2026 •

edited by jkotas

Loading