Reduce allocations during VsAppDomaiinManager.BindingPaths#9891
Closed
Reduce allocations during VsAppDomaiinManager.BindingPaths#9891
Conversation
Each call to the .net fx implementation of RegistryKey.GetValueNames allocates a 32KB array [here](https://github.com/microsoft/referencesource/blob/ec9fa9ae770d522a5b5f0607898044b7478574a3/mscorlib/microsoft/win32/registrykey.cs#L1084) , resulting in the VsAppDomaiinManager.BindingPaths allocating ~1.5MB of char arrays. Instead, use an approach more like what net core does [here](https://github.com/dotnet/runtime/blob/f27c573c56e7aa280f519770b0678305a70442ae/src/libraries/System.Private.CoreLib/src/Internal/Win32/RegistryKey.cs#L146) , utilizing the ERROR_MORE_DATA return value to resize and re-call RegEnumValue.
Member
|
@ToddGrun dotnet-project-system is now in devops, could you please resubmit the pr there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each call to the .net fx implementation of RegistryKey.GetValueNames allocates a 32KB array here , resulting in the VsAppDomaiinManager.BindingPaths allocating nearly ~30 MB of char arrays in one of our speedometer tests.
Instead, use an approach more like what net core does here , utilizing the ERROR_MORE_DATA return value to resize and re-call RegEnumValue.