Add dotnet/skills marketplace and enable plugins#13582
Merged
Evangelink merged 3 commits intomainfrom Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Copilot agent configuration file to register additional plugin marketplaces and enable a set of dotnet-related plugins for this repo.
Changes:
- Add
.github/copilot/settings.jsondefining two extra marketplaces (dotnet/arcade-skills,dotnet/skills) - Enable
dotnet-dnceng,dotnet,dotnet-msbuild,dotnet-nuget, anddotnet-testplugins from those marketplaces
Show a summary per file
| File | Description |
|---|---|
.github/copilot/settings.json |
Registers dotnet plugin marketplaces and enables selected dotnet plugins for Copilot agents |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
JanKrivanek
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
24-Dimension Expert Review — .github/copilot/settings.json
PR #13582 adds a Copilot agent configuration file that registers two plugin marketplaces and enables 5 plugins. This is a purely additive, non-code configuration change.
Verification Performed
- ✅
dotnet/arcade-skills— confirmed official dotnet org repo, containsplugins/dotnet-dnceng - ✅
dotnet/skills— confirmed official dotnet org repo (1,341 ★), containsplugins/dotnet,plugins/dotnet-msbuild,plugins/dotnet-nuget,plugins/dotnet-test - ✅ JSON is well-formed
- ✅ PR references related work (#13574)
Dimension Summary
| # | Dimension | Verdict | Notes |
|---|---|---|---|
| 1 | Backwards Compatibility | ✅ LGTM | New file, purely additive |
| 2 | ChangeWave Discipline | ✅ LGTM | N/A — no engine behavioral change |
| 3 | Performance & Allocation | ✅ LGTM | N/A — no runtime code |
| 4 | Test Coverage | ✅ LGTM | N/A — config file, no testable behavior |
| 5 | Error Message Quality | ✅ LGTM | N/A — no error messages |
| 6 | Logging & Diagnostics | ✅ LGTM | N/A — no logging |
| 7 | String Comparison | ✅ LGTM | N/A — no C# code |
| 8 | API Surface | ✅ LGTM | N/A — no API changes |
| 9 | Target Authoring | ✅ LGTM | N/A — no targets |
| 10 | Design Before Implementation | ✅ LGTM | Simple config, well-scoped |
| 11 | Cross-Platform | ✅ LGTM | N/A — JSON file |
| 12 | Code Simplification | ✅ LGTM | N/A — no code |
| 13 | Concurrency | ✅ LGTM | N/A — no runtime code |
| 14 | Naming Precision | ✅ LGTM | Plugin names follow dotnet conventions |
| 15 | SDK Integration | ✅ LGTM | N/A — no SDK changes |
| 16 | Idiomatic C# Patterns | ✅ LGTM | N/A — no C# code |
| 17 | File I/O & Path Handling | ✅ LGTM | N/A — no file I/O |
| 18 | Documentation Accuracy | ✅ LGTM | Config file, no doc update needed |
| 19 | Build Infrastructure | ✅ LGTM | Does not affect build pipeline |
| 20 | Scope & PR Discipline | ✅ LGTM | Single focused change, references #13574 |
| 21 | Evaluation Model | ✅ LGTM | N/A — no evaluation changes |
| 22 | Correctness & Edge Cases | ✅ LGTM | All 5 plugin names verified to exist |
| 23 | Dependency Management | ✅ LGTM | References trusted dotnet org repos only |
| 24 | Security Awareness | ✅ LGTM | Both repos are official dotnet org, MIT-licensed |
Result: 24/24 dimensions clear. No issues found.
Generated by Expert Code Review (on open) for issue #13582 · ● 2.3M
jankratochvilcz
requested changes
Apr 21, 2026
Contributor
jankratochvilcz
left a comment
There was a problem hiding this comment.
Thanks for the PR, let's discuss on the one comment and then merge!
JanProvaznik
approved these changes
Apr 21, 2026
ViktorHofer
approved these changes
Apr 21, 2026
Evangelink
commented
Apr 21, 2026
Member
Author
|
@jankratochvilcz done |
jankratochvilcz
approved these changes
Apr 21, 2026
Contributor
jankratochvilcz
left a comment
There was a problem hiding this comment.
Thanks, approving!
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.github/copilot/settings.jsonto configure Copilot agent plugin marketplaces and enable dotnet plugins:dotnet/arcade-skillsmarketplace withdotnet-dncengplugindotnet/skillsmarketplace withdotnet,dotnet-msbuild,dotnet-nuget, anddotnet-testpluginsRelates to (and should replace a big part of) #13574