Skip to content

Remove unactionable info from reviewer agent #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanKrivanek merged 3 commits into from
Apr 21, 2026
+18 −5
Merged

Remove unactionable info from reviewer agent #13578

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be06c15
Remove unactionable info from reviewer agent
JanKrivanek Apr 20, 2026
83be49d
Potential fix for pull request finding
JanKrivanek Apr 21, 2026
1cc7dc0
Reflect PR comments
JanKrivanek Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/agents/expert-reviewer.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,24 +646,29 @@ Use this to prioritize dimensions based on changed files.

**Important**: Use `create_pull_request_review_comment` (inline on diff), NOT `add_comment` (general PR comment). Only findings tied to a specific changed line should use this tool.

**Every inline comment must be actionable.** Do NOT post comments that only praise existing code, acknowledge good patterns, or say "looks good". If a dimension is clean, record it as LGTM in the summary table — do not leave an inline comment for it. Comments like "This is well-written 👍" or "Good use of X pattern" add noise without giving the author anything to act on.
Comment thread
JanKrivanek marked this conversation as resolved.
Outdated
Comment thread
JanKrivanek marked this conversation as resolved.
Outdated
Comment thread
JanKrivanek marked this conversation as resolved.
Outdated

6. Post design-level concerns (not tied to a specific diff line) as a single PR comment via the `add_comment` safe-output tool — one bullet each.

### Wave 4: Summary

7. Submit the final review verdict via the `submit_pull_request_review` safe-output tool. Include the summary table in the review `body` and set the `event` field:
7. Submit the final review verdict via the `submit_pull_request_review` safe-output tool. Include the summary table in the review `body` and set the `event` field.

**Omit all LGTM dimensions from the table** — only list dimensions that have findings. This keeps the review concise and actionable. Show the count of clean dimensions as a single summary line instead.

```markdown
| # | Dimension | Verdict |
|---|-----------|---------|
| 1 | Backwards Compatibility | ✅ LGTM |
| 13 | Concurrency | 🔴 2 MAJOR |
| 22 | Correctness | 🟡 1 MODERATE |

✅ 22/24 dimensions clean.
Comment thread
JanKrivanek marked this conversation as resolved.

- [x] Backwards Compat
- [ ] Concurrency — shared state race
- [ ] Correctness — null input edge case
```

`[x]` = LGTM or NITs only. `[ ]` = BLOCKING.
Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise (including all-clear) → event: **COMMENT**.
`[ ]` = dimensions with findings. Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise (including all-clear) → event: **COMMENT**.
**Never use APPROVE** — the agent must not count as a PR approval.

All inline comments from step 5 are automatically bundled into this review submission.
Loading