Skip to content

Curate and apply safe upstream Carnac PRs#3

Draft
Copilot wants to merge 2 commits intodevfrom
copilot/apply-prs-from-original-repo
Draft

Curate and apply safe upstream Carnac PRs#3
Copilot wants to merge 2 commits intodevfrom
copilot/apply-prs-from-original-repo

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 16, 2026

This PR reviews the open upstream Code52/carnac PR backlog and ports only the changes that are still reasonable, low-risk, and compatible with this fork. Broad stale behavior changes were intentionally left out; the applied set focuses on display positioning, keymap coverage, and accurate setup docs.

  • Applied upstream changes

  • Display positioning

    • Added PopupSettings.Top alongside the existing Left coordinate
    • Updated screen placement to persist both Left and Top for the selected monitor
    • Updated KeyShowView to react to Top changes, so overlays position correctly on vertically arranged displays
    • Removed preview scaling from ScreenManager.Top, so saved coordinates use actual monitor origin values
  • Keymap support

    • Added src/Carnac.Logic/Keymaps/kdenlive.yml
    • Registered the new keymap in Carnac.Logic.csproj
    • Normalized shortcut entries to the syntax supported by the current legacy parser, avoiding dead or non-parsable mappings
  • Docs cleanup

    • Updated installation instructions to include WinGet
    • Replaced deprecated cinst usage with choco install carnac
    • Corrected contributor setup guidance to reference the existing PowerShell build entrypoint in this fork
  • Focused coverage

    • Added a view-model test to verify that selecting a screen copies both horizontal and vertical origin values into settings
Settings.Left = SelectedScreen.Left;
Settings.Top = SelectedScreen.Top;

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Review and apply PRs from original repository Curate and apply safe upstream Carnac PRs Mar 16, 2026
Copilot AI requested a review from doggy8088 March 16, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants