Add killCursors tests#251
Open
danielfrankcom wants to merge 3 commits into
Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (1922+5 LOC, 14 files); LLM: Adds new test coverage for the killCursors command along with a minor type declaration fix in the test framework executor. If a label is wrong, remove it manually and ping |
Relocate the cursor test helpers from killCursors/utils to the shared commands/utils location and update the killCursors imports, so this branch aligns with the getMore branch and merges cleanly. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
yshanhu
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
killCursorscommand.I also fixed a type declaration issue in
documentdb_tests/framework/executor.pywhich was causing a type error for one of the tests.