Skip to content

Added projection test cases for $slice#235

Open
vic-tsang wants to merge 1 commit into
documentdb:mainfrom
vic-tsang:projection/slice/tests
Open

Added projection test cases for $slice#235
vic-tsang wants to merge 1 commit into
documentdb:mainfrom
vic-tsang:projection/slice/tests

Conversation

@vic-tsang
Copy link
Copy Markdown
Collaborator

@vic-tsang vic-tsang commented May 25, 2026

This PR contains:

  • projection test cases for $slice
  • introduced skip_rejection_types for BSON comparison test cases as the engine converted some of the projection slice into valid expression slice which didn't result in error (the skipped test cases are tested outside the framework from line 189 in test_slice_projection_behavior.py)
  • renamed error code EXPRESSION_SLICE_NOT_ARRAY_ERROR to SLICE_INVALID_ARGUMENT_ERROR

Ref:

@vic-tsang vic-tsang requested a review from a team as a code owner May 25, 2026 19:46
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 25, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.85 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (1167+1 LOC, 11 files); LLM: Adds new projection test cases for the $slice operator under the compatibility tests path, expanding test coverage for an existing feature.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@vic-tsang vic-tsang force-pushed the projection/slice/tests branch from 252a670 to e7c58b1 Compare May 25, 2026 21:27
@vic-tsang vic-tsang requested a review from fanyangv May 29, 2026 22:20
Signed-off-by: Victor Tsang <vitsangp@amazon.com>
@vic-tsang vic-tsang force-pushed the projection/slice/tests branch from 9970183 to d3d27f8 Compare May 29, 2026 23:39
@vic-tsang
Copy link
Copy Markdown
Collaborator Author

vic-tsang commented May 29, 2026

rebased and addressed review's comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants