Skip to content

ci(e2e): trigger on submodule-only PRs#838

Merged
doringeman merged 1 commit intodocker:mainfrom
doringeman:e2e-trigger-submodule-prs
Apr 7, 2026
Merged

ci(e2e): trigger on submodule-only PRs#838
doringeman merged 1 commit intodocker:mainfrom
doringeman:e2e-trigger-submodule-prs

Conversation

@doringeman
Copy link
Copy Markdown
Contributor

Trigger e2e tests on submodule-only PRs, which GitHub Actions does not match with the default ** glob (e.g., #834).

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding an inline comment above the special llamacpp/native/vendor/llama.cpp path entry explaining that it’s a workaround for submodule-only PRs not matching ** (ideally with a link to the upstream GitHub Actions issue or the referenced PR), so future maintainers understand why this seemingly redundant pattern is needed.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding an inline comment above the special `llamacpp/native/vendor/llama.cpp` path entry explaining that it’s a workaround for submodule-only PRs not matching `**` (ideally with a link to the upstream GitHub Actions issue or the referenced PR), so future maintainers understand why this seemingly redundant pattern is needed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@doringeman doringeman merged commit 2952c0c into docker:main Apr 7, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants