Skip to content

build: GitHub Builder runner mappings#25086

Merged
crazy-max merged 1 commit into
docker:mainfrom
crazy-max:github-builder-runner
May 18, 2026
Merged

build: GitHub Builder runner mappings#25086
crazy-max merged 1 commit into
docker:mainfrom
crazy-max:github-builder-runner

Conversation

@crazy-max
Copy link
Copy Markdown
Member

follow-up docker/github-builder#188

The reusable workflows now accept either a GitHub-hosted Linux runner label or a newline-delimited platform mapping, while the legacy auto, amd64, and arm64 values are deprecated.

@crazy-max crazy-max requested a review from dvdksn May 18, 2026 10:02
@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e79ee7e
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a0b16f387f4380008c25d4c
😎 Deploy Preview https://deploy-preview-25086--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the area/build Relates to Dockerfiles or docker build command label May 18, 2026
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

@crazy-max crazy-max force-pushed the github-builder-runner branch from 6ef9438 to ef98c43 Compare May 18, 2026 10:12

### Runner selection

The `runner` input accepts either a single GitHub-hosted Linux runner label or a
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a page we could link to in the GitHub docs that shows the available labels?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +48 to +61
newline-delimited platform mapping. A single label is used for every platform:

```yaml
runner: ubuntu-24.04
```

The default value is a platform mapping that uses GitHub-hosted Ubuntu runners:

```yaml
runner: |
default=ubuntu-24.04
linux/arm=ubuntu-24.04-arm
linux/arm64=ubuntu-24.04-arm
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we re-order this to show the default first, and what it resolves to after.

Suggested change
newline-delimited platform mapping. A single label is used for every platform:
```yaml
runner: ubuntu-24.04
```
The default value is a platform mapping that uses GitHub-hosted Ubuntu runners:
```yaml
runner: |
default=ubuntu-24.04
linux/arm=ubuntu-24.04-arm
linux/arm64=ubuntu-24.04-arm
```
newline-delimited platform mapping.
The default value is a platform mapping that uses GitHub-hosted Ubuntu runners:
```yaml
runner: |
default=ubuntu-24.04
linux/arm=ubuntu-24.04-arm
linux/arm64=ubuntu-24.04-arm
```
In the platform job, the runner label resolves to a single value:
```yaml
runner: ubuntu-24.04
```

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sounds better indeeed

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the github-builder-runner branch from ef98c43 to e79ee7e Compare May 18, 2026 13:41
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@crazy-max crazy-max merged commit ec6d849 into docker:main May 18, 2026
15 checks passed
@crazy-max crazy-max deleted the github-builder-runner branch May 18, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants