container/ps: add HealthCheck formatter field#6913
Open
Mohammed-Thaha wants to merge 1 commit intodocker:masterfrom
Open
container/ps: add HealthCheck formatter field#6913Mohammed-Thaha wants to merge 1 commit intodocker:masterfrom
Mohammed-Thaha wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Mohammed Thaha <mohammedthahacse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added a new
docker ps --formatplaceholder:.HealthCheck, so users can print container health state directly as a dedicated field.Fixes #6203.
- How I did it
HealthCheck()to the container formatter context.c.c.Health.Statuswhen available..Statustext for:(healthy)->healthy(unhealthy)->unhealthy(health: starting)->startingdocs/reference/commandline/container_ls.mdto include.HealthCheckin the format placeholders table.cli/command/formatter/container_test.go.- How to verify it
Start dev shell:
Build the CLI binary:
Run a container that stays in
startingduring the start period:Verify formatter output:
./build/docker-linux-amd64 ps -a --filter name=hc-starting --format "table {{.Names}}\t{{.Status}}\t{{.HealthCheck}}"Expected result:
STATUScontains(health: starting)HEALTHCHECKshowsstarting- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)