Skip to content

pre-ship checklist #12

Description

@dmarx

Features

  • node which facilitates combining and normalizing lots of conds/curves for the user

    • combine manny
    • [ ] combine many and normalize
  • arithmetic reductions (sum, prod) that take more than 2 inputs

  • ensure we have a satisfactory install sequence.

    • i think right now the dependencies are just in requirements.txt. check other nodes for best practice install sequence
  • drawing functionality for schedules

  • node to collect several curves into a single pgroup

  • pgroup vs curve arithmetic

  • pgroup reductions (broken upstream?)

    • sum over pgroup
    • prod over pgroup

Bugs

  • cond addition is not order invariant and changing order can result in undercooked/deepfried animations
    • sprinkle deepcopy around core.py nodes
  • interpolators not working on schedule
    • exp_decay - missing parameter
    • sine_wave - throws error on a division operation

documentation

  • screenshots of new nodes in readme
    • parameter group stuff
    • drawing utilities
  • update workflow images for aliased names and new nodes
  • add demo for superposition with utility nodes
  • link out from keyframed to comyui-keyframed
    • do a release of keyframed as well. low hanging fruit: add total_ordering to Keyframed class
  • expand curve drawing demo
    • add yaml-initialized fancy curve to drawing demo
    • sinusoidal
    • superposition
    • different interpolators
    • LFOs (once those are a thing)

Scope Creep (move to next release

  • LFOs
  • combine many and normalize
  • 1-x operator

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions