make clean_error_msg public for protocol class users#371
Open
Coservit wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
first, thanks for this library, really useful when managing windows host.
It seem the winrm.session class does not handle other code page except ascii, and the recommended way to go is using the protocol object if we need other codepage (see issue 258, 357, 333)
I use the protocol object successfully, but need to decode the clixml message if there is an error.
for that _clean_error_message is a useful method, but it's not accessible from the protocol object, and it's not public.
could you make this function public for everyone to use, without having to create a session object ?
tested on python3.10