Add a function to send input to a running process.

[rustyscottweber]

This should put to rest Issue 72. This expands the capabilities of pywinrm to be able to send input to an already running process.

[rustyscottweber]

My suggestion is that we create a release for this once checked in.

[coveralls]

Coverage increased (+0.3%) to 76.797% when pulling ccc8cff on rustyscottweber:stdin_development into fe59460 on diyan:master.

[rustyscottweber]

@diyan , I'm having some difficulties understanding your unit tests, it would appear that you have mocked the function for returning a message, but the response is predetermined off of what the message being sent was. I'm not sure how the xml in these sections should look. Can you lend a hand and tell me how I can figure out how I can patch the tests to get this function checked in or finish up the tests yourself?

[badcure]

@rustyscottweber The XML location currently is at https://github.com/diyan/pywinrm/blob/master/winrm/tests/conftest.py . These are just mocked responses, and what I believe how py.test sets up each test.

That said, I am hoping to redo how the unit tests are done. The initial PR is #270 . Feel free to look over that as well if you have any comments, I think once that is merged...I hope it will be a little easier to understand/write tests.

[rustyscottweber]

If that is the case, should I even worry about the unit test and just check in code as is?

…

On Sun, Aug 11, 2019, 10:25 Brian Price ***@***.***> wrote: @rustyscottweber <https://github.com/rustyscottweber> The XML location currently is at https://github.com/diyan/pywinrm/blob/master/winrm/tests/conftest.py . These are just mocked responses, and what I believe how py.test sets up each test. That said, I am hoping to redo how the unit tests are done. The initial PR is #270 <#270> . Feel free to look over that as well if you have any comments, I think once that is merged...I hope it will be a little easier to understand/write tests. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#271?email_source=notifications&email_token=ABDUWG2DJAWKC5FH4BR7YMLQEA4PRA5CNFSM4IK2QOMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BEBAY#issuecomment-520241283>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDUWGZ7JA72LKJF7WUBAIDQEA4PRANCNFSM4IK2QOMA> .

[badcure]

And yes, please include unit tests. At the very least, it should ensure the code works.

Looking at conftest.py, you will have the provide the proper request xml(i.e. the one you are creating) and return a response. I think you tie it all in over here: https://github.com/diyan/pywinrm/blob/master/winrm/tests/conftest.py#L332-L352

[jborean93]

Would be great if you could also add the tests for some of the encoding examples I had in my comments.

[rustyscottweber]

Are there any more outstanding issues? Or can this be merged?

[rustyscottweber]

I believe that there are no longer any outstanding issues. Is there anything else that needs to be reviewed before merging?

[jborean93]

The issues I had have been fixed, up to @badcure to do the final merge once he's ready.