Skip to content

Fix decoding for local date #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drewfeelsblue wants to merge 1 commit into
base: series/0.19
Choose a base branch
from
Open

Fix decoding for local date #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/json/src/smithy4s/json/internals/SchemaVisitorJCodec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,9 @@ private[smithy4s] class SchemaVisitorJCodec(
def expecting: String = "localDate"

def decodeValue(cursor: Cursor, in: JsonReader): LocalDate =
LocalDate.parseUnsafe(in.readString(null))
LocalDate
.parse(in.readString(null))
.getOrElse(in.decodeError("expected " + expecting))

def encodeValue(x: LocalDate, out: JsonWriter): Unit =
out.writeNonEscapedAsciiVal(x.toString())
Expand Down
11 changes: 11 additions & 0 deletions modules/json/test/src/smithy4s/json/SchemaVisitorJCodecTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,17 @@ class SchemaVisitorJCodecTests() extends FunSuite {

}

test("throw PayloadError for invalid local date") {
try {
implicit val schema: Schema[LocalDate] = localdate

readFromString[LocalDate]("\"2026-33-12\"")
fail("Unexpected success")
} catch {
case PayloadError(_, expected, _) => expect.same(expected, "localDate")
}
}

test("Optional encode from present value") {
val foo = Foo(1, Some(2))
val json = """{"a":1,"_b":2}"""
Expand Down