Add crossfade and update UI#2
Open
glowcone wants to merge 2 commits into
Open
Conversation
Member
|
Good stuff! Having the JS inside the HTML was intentional, as the NodeMCU cannot handle multiple requests at the same time. I have since built 'pipelining' into nodemcu-httpd, but that version has not been uploaded to the lights yet. Personally I would keep everything in one file for performance: the thing is sloooow. |
Author
|
@lionello Oh I see. Also, I found that my uploaded version of rgb.lua was an older one (and does not work), so I had replaced it through my last commit. |
ppaeps
pushed a commit
that referenced
this pull request
Jul 27, 2024
Optimize memory; call connection:close() in send() callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also separated JS code into new file