feat(messages): add control lifecycle contracts - #25
Open
TomCC7 wants to merge 2 commits into
Open
Conversation
Both the Rust and TypeScript steps `rm -rf` their whole output directory
before regenerating, but the generators only own part of what lives
there. Every run destroyed generated/rust_lcm_msgs/{.gitignore,tests/}
and generated/ts_lcm_msgs/{mod.ts,deno.json}, so anyone running
generate.sh got four spurious deletions in their diff.
Clear only what each generator actually rewrites: src/ for the Rust
crate (it owns src/ and Cargo.toml), and the per-package directories for
TypeScript (the root files are hand-written in tools/ts/msgs/). The copy
into tools/ts/msgs/generated now takes the package directories
explicitly, which is what it effectively copied before.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dimos_core_msgs.ModuleReadinessdimos_control_msgsThe generator-preservation commit is the same commit already reviewed on #24; it is included here because it has not landed on
mainand clean generation otherwise deletes checked-in files.Validation
nix develop --command ./generate.shpython -m unittest tests/test_control_contracts.py -vruff check generated/python_lcm_msgs/fix_imports.py tests/test_control_contracts.pypython -m buildDependency for dimensionalOS/dimos#3409 PR3.