Skip to content

589: add privacy policy and imprint links - #955

Draft
sascha11110 wants to merge 1 commit into
mainfrom
589-privacy-policy-and-imprint-links
Draft

589: add privacy policy and imprint links#955
sascha11110 wants to merge 1 commit into
mainfrom
589-privacy-policy-and-imprint-links

Conversation

@sascha11110

Copy link
Copy Markdown
Contributor

Both URLs are configurable via LUNES_CMS_PRIVACY_POLICY_URL and LUNES_CMS_IMPRINT_URL. They are rendered in the admin user menu, the admin footer, the login page and on the public upload page.

Fixes: #589

Bildschirmfoto 2026-08-18 um 10 12 33

PRIVACY_POLICY_URL = https://lunes.app/datenschutz
# URL of the imprint, linked in the same places as the privacy policy
# [optional, defaults to an empty string which hides the link]
IMPRINT_URL = https://lunes.app/impressum/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOs:

  • Privacy policy for CMS
  • Configure on test and production environment

Both URLs are configurable via LUNES_CMS_PRIVACY_POLICY_URL and
LUNES_CMS_IMPRINT_URL. They are rendered in the admin user menu, the
admin footer, the login page and on the public upload page. A link
whose URL is not configured is left out entirely.
@sascha11110
sascha11110 force-pushed the 589-privacy-policy-and-imprint-links branch from 1c0870c to 376666b Compare August 18, 2026 08:49
@deliverino

deliverino Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

LLM Review (verdigado-think)

The pull request follows the project's engineering standards and conventions.

Review Details:

  • Django correctness: No model changes were made, so no migrations are required.
  • Internationalization: The new strings "Privacy policy" and "Imprint" have been correctly added to lunes_cms/locale/de/LC_MESSAGES/django.po without fuzzy markers.
  • Type safety: New functions in lunes_cms/core/context_processors.py and lunes_cms/core/utils.py are fully type-annotated.
  • Code quality: The use of # pylint: disable=unused-argument in the context processor is justified as the request argument is required by the Django context processor signature.
  • Security: No security-sensitive code (uploads, CSRF, keys) was modified.
  • Testing: The new tests/core/test_legal_links.py provides good coverage for both the template rendering (authenticated and anonymous) and the helper logic.
  • Commit message: The commit message follows the required convention (<ticket>: <summary> in lowercase).
  • Labels: The changes are user-facing (adding visible links to the admin and public pages), so the absence of a label is correct as it belongs in the "Features, Fixes & Enhancements" category.

@LeandraH LeandraH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, even with the draft links! Also, great idea to move the links themselves to Salt!

One small nit, I think the links should probably also be shown on the log out page :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy Policy & Imprint Links

2 participants