823: Add example sentence to word list - #944
Open
JoeyStk wants to merge 5 commits into
Open
Conversation
JoeyStk
force-pushed
the
add-example-sentence
branch
from
August 12, 2026 15:55
f83ae9d to
75bde9e
Compare
Contributor
LLM Review (verdigado-think)1. Django Correctness
2. Internationalization
3. Type Safety
4. Code Quality Gates
5. Security
6. Testing
8. Commit Message Style
|
JoeyStk
requested review from
LeandraH,
david-venhoff,
f1sh1918,
qaiser42 and
sascha11110
August 12, 2026 16:05
JoeyStk
marked this pull request as ready for review
August 12, 2026 16:09
JoeyStk
force-pushed
the
add-example-sentence
branch
from
August 13, 2026 09:52
ae8bba6 to
9c9fff1
Compare
LeandraH
reviewed
Aug 19, 2026
LeandraH
left a comment
Contributor
There was a problem hiding this comment.
Great refactoring!
A couple of things:
Have you already gone through the points from the AI review? There might be some valid points in there.
Be careful when fixing the merge conflicts, you might accidentally overwrite #950
I think the audio of the sentence needs to be checked from the overview as well, so a play button there would be awesome!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the few pieces for #823. I decided to split the issue in multiple PRs, to keep it as reviewable as possible and more importantly, to ship the most important feature on the next occasion. From there we can slowly add the details. This also gives us the advantage of having short cycles for feedback.
Proposed changes
How to test
Resolved issues
Fixes: Parts of #823