Replace Sphinx docs with MkDocs Material#272
Conversation
mielvds
left a comment
There was a problem hiding this comment.
Very nice and also long overdue! I added some comments, nothing major. I can think of many things to add ofc., but I'll leave these for upcoming PR's. It would be nice to include this in the next release.
| test: | ||
| pytest --cov=pyld | ||
|
|
||
| serve: |
There was a problem hiding this comment.
If you can serve the docs from make, I'd expect you can build them too (including installing the deps).
| @@ -1 +1,3 @@ | |||
| sphinx-autobuild | |||
| -r ../requirements.txt | |||
| mkdocs-material | |||
|
|
||
| PyLD is compatible with `Python`_ 2.5 and newer. | ||
|
|
||
| Credits |
There was a problem hiding this comment.
Can we have a spot for this somewhere? Maybe it's time to add ourselves as current maintainers ;)
| @@ -0,0 +1,40 @@ | |||
| # PyLD | |||
|
|
|||
| PyLD is a Python implementation of the [JSON-LD][] processor API. | |||
|
|
||
| PyLD aims to conform with: | ||
|
|
||
| - [JSON-LD 1.1][json-ld-11] |
There was a problem hiding this comment.
If possible, I'd like to see a table that links to the skipped tests
| - [JSON-LD 1.1][json-ld-11] | ||
| - [JSON-LD 1.1 Processing Algorithms and API][json-ld-11-api] | ||
| - [JSON-LD 1.1 Framing][json-ld-11-framing] | ||
| - The JSON-LD Working Group [test suite][wg-test-suite] |
There was a problem hiding this comment.
Also mention the normalization algorithms?
| @@ -0,0 +1,135 @@ | |||
| # API Reference | |||
There was a problem hiding this comment.
This was generated using some tool?
| @@ -0,0 +1,57 @@ | |||
| # Document Loaders | |||
There was a problem hiding this comment.
Add a similar document on ContextResolver? (see README)
Co-authored-by: Anatoly Scherbakov <altaisoft@gmail.com>
Co-authored-by: Anatoly Scherbakov <altaisoft@gmail.com>
|
@mielvds thanks for the review! I haven't yet had a chance to get back to this PR but I will shortly (probably on the weekend) |
|
NP! The markdown conversion is now merged, but I totally forgot to add a link to the documentation in README.md. Maybe add this as well :) |
Fixes #259. Documentation at https://digitalbazaar.github.io/pyld/
Summary
make servetargetValidation
.venv/bin/mkdocs build --strict