Skip to content

bug/VSPC-283#373

Open
Girik1105 wants to merge 6 commits into
developfrom
bug/VSPC-283
Open

bug/VSPC-283#373
Girik1105 wants to merge 6 commits into
developfrom
bug/VSPC-283

Conversation

@Girik1105

@Girik1105 Girik1105 commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

Button to resize the space background image on the public page doesn't work properly

In some cases, nothing happens (probably when the image is too small?) and in some cases it extends the image beyond the browser size.
What should happen is that if the image isn’t big enough, the button should be disabled and if the user hovers over it, it should say “Image is not big enough to expand.” If the image is big enough it should take up the whole screen (so move image to the left and then fill up the whole browser width).

VSPC-283

Anything else the reviewer needs to know?

... describe here ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant