bug/VSPC-283#373
Open
Girik1105 wants to merge 6 commits into
Open
Conversation
…s for larger images within browser width, links expand appropriately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
Button to resize the space background image on the public page doesn't work properly
In some cases, nothing happens (probably when the image is too small?) and in some cases it extends the image beyond the browser size.
What should happen is that if the image isn’t big enough, the button should be disabled and if the user hovers over it, it should say “Image is not big enough to expand.” If the image is big enough it should take up the whole screen (so move image to the left and then fill up the whole browser width).
VSPC-283
Anything else the reviewer needs to know?
... describe here ...