perf: L2 cache NONSTRICT + eviction guard (#24810, #24916) [2.41] - #24987
Closed
netroms wants to merge 6 commits into
Closed
perf: L2 cache NONSTRICT + eviction guard (#24810, #24916) [2.41]#24987netroms wants to merge 6 commits into
netroms wants to merge 6 commits into
Conversation
2.41 has no JCacheDomainDataRegionImpl. EhcacheRegionFactory builds Hibernate's DomainDataRegionImpl, which is the correct superclass here.
#24916's GuardedJCacheRegionFactory has no safe Ehcache 2 counterpart: H2 controller tests then fail with null Period, invalid period ISO, and a closed EntityManagerFactory. #24827 (NONSTRICT only) is green on 2.41. Keep the cache-strategy switch and predefined regions; leave the guard on JCache branches.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24810, adapted for Ehcache 2.
2.41 still uses hibernate-ehcache / Ehcache 2, not master's JCache stack. Reference-metadata cache strategy is switched in hbm.xml. Hot regions are predefined in ehcache.xml. TTL capped at one hour.
#24916 (eviction guard) is not included: wiring it through EhcacheRegionFactory broke Period resolution and collapsed the SessionFactory in H2 controller tests. #24827 (NONSTRICT only) is green on 2.41.
#24767 (ramp harness) is not included: 2.41 has no gatling performance module.
Overlaps #24827.
AI Assisted