Repository navigation
ci: fix three external e2e regressions - #4546
Merged
Merged
Conversation
vite-plugin-environment 1.1.4, published 2026-09-09, raises its peer dependency from `vite >= 2.7` to `vite >= 8.0`. The templates ask for `^1.1.3` and pin vite at ^4.3.9 (^5.4.3 for svelte), so npm resolves the plugin to 1.1.4 and `npm install` fails with ERESOLVE in a newly created project. That leaves node_modules empty, and the build step then fails with `tsc: command not found`. Ask for exactly 1.1.3 in all four frontend templates. Verified that each of the four resolves with the pin and that vanilla_js fails without it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bitcoin.org no longer serves the bitcoin-core binaries and returns 404, which fails the bitcoin e2e job before any test runs. bitcoincore.org serves the same release; the existing sha256 check on the tarball is unchanged and still verifies what is downloaded. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ic-mops 3.0.0, published 2026-08-20, removed the `toolchain init` and `toolchain reset` subcommands. setup_playground calls `mops toolchain init` to install the moc version the playground backend builds with, so an unpinned `npm i -g ic-mops` now installs 3.x and every playground test fails in setup with "unknown command 'init'". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lwshang
marked this pull request as ready for review
September 22, 2026 07:06
lwshang
enabled auto-merge (squash)
September 22, 2026 07:06
|
✅ No security or compliance issues detected. Reviewed everything up to 6322594. Security OverviewDetected Code Changes
|
marc0olo
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three upstream regressions broke e2e. All three landed after master's last e2e run on
2026-06-23, which is why master appears green. Split out of #4545 so each has its own
bisect point.
fix: pin vite-plugin-environment to 1.1.3— 1.1.4, published 2026-09-09, raises its peerdependency from
vite >= 2.7tovite >= 8.0. The frontend templates ask for^1.1.3againstvite^4.3.9 (^5.4.3 for svelte), sonpm installin a newly created project fails withERESOLVE,
node_modulesstays empty, and the build then fails withtsc: command not found.This broke every job that deploys a frontend project:
smoke,ui_test,dfx/new,dfx/info,dfx/telemetry,dfx/playground,dfx/frontend,dfx/deploy, and onedfx/assetscanistercase.
ci: download bitcoin core from bitcoincore.org— bitcoin.org no longer serves thebitcoin-core binaries and returns 404, failing the
dfx/bitcoinjobs during provisioning.bitcoincore.org serves the same release; the existing sha256 check on the tarball is unchanged
and still verifies what is downloaded.
ci: pin ic-mops to 2.24.0 in the playground e2e test— ic-mops 3.0.0, published2026-08-20, removed the
toolchain initandtoolchain resetsubcommands.setup_playgroundcalls
mops toolchain init, so an unpinnednpm i -g ic-mopsinstalls 3.x and all sixplayground tests fail in setup with
unknown command 'init'.How Has This Been Tested?
(control).
npx ic-mops@2.24.0 toolchain --helplistsinit;@3.2.3does not.curl -Ireturns 404 from bitcoin.org and 200 from bitcoincore.org for the same tarball.Checklist:
🤖 Generated with Claude Code