feat: extend dfx canister update-settings to support --sync-with - #4378
Merged
Merged
Conversation
mraszyk
reviewed
Sep 8, 2025
mraszyk
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Leaving a few notes:
- Let's make sure that environment variables are added to this new flow once they are enabled in production.
- Let's maybe print a warning if the user is not a controller after the sync, e.g., if the user tried to sync settings of a black-holed canister.
Contributor
Author
The function will output error messages like below |
vincent-dfinity
marked this pull request as ready for review
September 8, 2025 12:48
lwshang
reviewed
Sep 8, 2025
lwshang
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend
dfx canister update-settingsto support--sync-with, an example as below--yes, the command will output thefrom_canistersettings and ask for consent as below--yes, it won't ask for consent and start syncing immediately.Fixes # (issue)
SDK-2045
How Has This Been Tested?
Added a new e2e test.
Checklist: