Skip to content

ci(docs): build the docs site on Node 24 - #849

Merged
lwshang merged 1 commit into
mainfrom
lwshang/docs-node-24
Oct 26, 2026
Merged

lwshang merged 1 commit into
mainfrom
lwshang/docs-node-24

Conversation

@lwshang

@lwshang lwshang commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Astro 7.4 requires Node >=22.23.4. In docs.yml, setup-node is set to node-version: '22', which uses the runner's cached 22.23.3, so the Dependabot astro bump (#843) fails at astro build:

Node.js v22.23.3 is not supported by Astro!
Please upgrade Node.js to a supported version: ">=22.23.4"

This PR moves all four docs.yml jobs to Node 24 (Active LTS), which release-npm.yml already uses. It has to be a separate PR because .github/repo_policies/BOT_APPROVED_FILES doesn't let Dependabot change workflow files. Once this merges, rebase #843.

🤖 Generated with Claude Code

astro 7.4 requires Node >=22.23.4, but setup-node's '22' resolves to the
runner's cached 22.23.3, so the astro bump (#843) fails to build.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lwshang
lwshang requested a review from a team as a code owner October 26, 2026 08:49
Copilot AI balanced review requested due to automatic review settings October 26, 2026 08:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The four consistent runtime updates satisfy the stated Astro requirement, with no identified blocking issues.

No open issues 🎉

What changed in this PR

Updates the documentation workflow to Node 24 to satisfy Astro’s minimum Node requirement and unblock the dependency upgrade in #843.

Changes:

  • Switches all four docs.yml jobs from Node 22 to Node 24.
  • Aligns the documentation workflow with the Node version used by release-npm.yml.
File Description
.github/​workflows/​docs.yml Updates all four Node setup steps to Node 24.

Review effort: Balanced

@lwshang
lwshang enabled auto-merge (squash) October 26, 2026 08:54
@lwshang
lwshang merged commit a791363 into main Oct 26, 2026
107 checks passed
@lwshang
lwshang deleted the lwshang/docs-node-24 branch October 26, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants