Repository navigation
ci(docs): build the docs site on Node 24 - #849
Merged
Merged
Conversation
astro 7.4 requires Node >=22.23.4, but setup-node's '22' resolves to the runner's cached 22.23.3, so the astro bump (#843) fails to build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The four consistent runtime updates satisfy the stated Astro requirement, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates the documentation workflow to Node 24 to satisfy Astro’s minimum Node requirement and unblock the dependency upgrade in #843.
Changes:
- Switches all four
docs.ymljobs from Node 22 to Node 24. - Aligns the documentation workflow with the Node version used by
release-npm.yml.
| File | Description |
|---|---|
.github/workflows/docs.yml |
Updates all four Node setup steps to Node 24. |
Review effort: Balanced
lwshang
enabled auto-merge (squash)
October 26, 2026 08:54
raymondk
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astro 7.4 requires Node
>=22.23.4. Indocs.yml,setup-nodeis set tonode-version: '22', which uses the runner's cached 22.23.3, so the Dependabot astro bump (#843) fails atastro build:This PR moves all four
docs.ymljobs to Node 24 (Active LTS), whichrelease-npm.ymlalready uses. It has to be a separate PR because.github/repo_policies/BOT_APPROVED_FILESdoesn't let Dependabot change workflow files. Once this merges, rebase #843.🤖 Generated with Claude Code