Repository navigation
chore(deps): fix RUSTSEC-2026-0385/0386/0387 - #844
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
crypto-bigint 0.5 has no fix for the non-constant-time arithmetic in RUSTSEC-2026-0387; it is pinned by the elliptic-curve 0.13 stack and by our own SLIP-0010 code. Move k256/p256/elliptic-curve to 0.14, pkcs8 to 0.11, sec1 to 0.8, crypto-bigint to 0.7, scrypt to 0.12 and bip32 to 0.6. ic-agent and friends come from the matching agent-rs branch via [patch.crates-io] until it is released; deny.toml allows that git source for now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
lwshang
changed the title
…26-0387" This reverts commit a364562.
…tCrypto 0.14 stack crypto-bigint 0.5 has no patched release and is pinned by ic-agent's elliptic-curve 0.13 stack. The fix is in progress in dfinity/agent-rs#745; the migration that was here moves to its own PR to wait for that release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 tasks
lwshang
marked this pull request as ready for review
October 26, 2026 07:47
lwshang
enabled auto-merge (squash)
October 26, 2026 07:47
raymondk
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the
cargo denyadvisories that fail thedependencies:requiredjob (seen on #842):ctutils): lockfile bump 0.4.2 → 0.4.6.tokioAsyncFdunsoundness): lockfile bump 1.53.1 → 1.54.1.crypto-bigintnon-constant-time arithmetic): ignored indeny.toml, with a reason.crypto-bigint0.5 has no fixed release, and ic-agent's elliptic-curve 0.13 stack pins it. A timing side channel is a remote risk for a local CLI that signs only with the user's own keys. The real fix is in chore!: upgrade RustCrypto elliptic-curve stack to 0.14 for RUSTSEC-2026-0387 agent-rs#745 and chore(deps): move to the RustCrypto 0.14 stack for RUSTSEC-2026-0387 #845, which removes this ignore.This is the first ignored vulnerability, so the
[advisories]comment now says an exception needs a fix already in progress and a link to it.The history has a migration commit and its revert. The migration moved to #845 to wait for the ic-agent release, so the net diff is just
Cargo.lockanddeny.toml.Tested locally:
cargo deny checkpasses in full (advisories ok, bans ok, licenses ok, sources ok), andcargo check --workspacepasses.🤖 Generated with Claude Code