Repository navigation
docs: add changelog entries for macOS codesigning and the crate refactor - #789
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation changes are clear, scoped, and have no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Unreleased changelog entries for macOS code signing and the internal crate refactor.
Changes:
- Documents signed macOS binaries, distribution channels, and Keychain benefits.
- Summarizes the
icp-project/icp-apprefactor with no user-facing impact.
| File | Description |
|---|---|
CHANGELOG.md |
Adds both Unreleased changelog entries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
marc0olo
approved these changes
Sep 24, 2026
marc0olo
left a comment
marc0olo
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Two optional tweaks:
- I'd drop the
dfinity/tapmention unless we add a stableicp-cliformula there. Right now it only has the leftovericp-cli-beta, which we don't advertise anymore. - Maybe add that the macOS binary isn't notarized, so a tarball downloaded through a browser still gets a Gatekeeper warning.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Unreleasedchangelog entries for two recent changes:dfinity/tap, npm — not homebrew-core, which Homebrew builds from source).icp→icp-project/icp-apprefactor stack (refactor: RemoveContextfrom operations #770–chore: Add CI for ensuring icp-project builds on wasm #776), summarized briefly since it has no user-facing effect.🤖 Generated with Claude Code