Repository navigation
chore: Release candid 0.10.36 - #769
Merged
Merged
Conversation
Contributor
|
✅ No security or compliance issues detected. Reviewed everything up to e2ddf61. Security OverviewDetected Code Changes
|
tools/ui patches candid to the workspace path, so its lockfile pins the path crate's version. It was left at 0.10.35 by the version bump, which breaks the --locked didjs build in candid-ui-release.yml. That workflow runs on the date tag this release creates, so it is not covered by PR checks. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
marc0olo
approved these changes
Sep 22, 2026
marc0olo
left a comment
Contributor
There was a problem hiding this comment.
Lockfile fix confirmed. --locked now passes in all three workspaces, and the
verbatim didjs build command from candid-ui-release.yml builds clean — so the
date-tag workflow will go through.
Release itself checks out: no source changes, no 0.10.35 left anywhere, and the
changelog covers exactly #767 and #768, both on master. cargo test -p candid --features all green.
Non-blocking: rust/candid/fuzz/Cargo.lock is still at 0.10.34, stale since
before this release. Nothing builds it with --locked, but worth a checklist
line so all four lockfiles move together next time.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release of
candid/candid_derive, 0.10.35 → 0.10.36. No source changes — it dates the two decoder fixes that are already onmaster.Summary
candidandcandid_derive0.10.35 → 0.10.36 (and the=pin between them), refreshCargo.lock,rust/bench/Cargo.lockandtools/ui/Cargo.lockUnreleasedCHANGELOG entries into a dated2026-09-22/Candid 0.10.36section, covering:tools/uipatchescandidto the workspace path, so its lockfile pins the path crate's version and has to move with the bump.candid-ui-release.ymlbuildsdidjsthere with--lockedand triggers on the date tag this release creates, so a stale lock there would only fail at tag time, after merge — not in PR checks.Test plan
cargo check -p candid -p candid_derive -p candid_parsercargo test -p candid— all suites passcd tools/ui && cargo build --target wasm32-unknown-unknown --profile canister --package didjs --locked— the release workflow's exact command, succeedsFollow-up (not in this PR)
rust/candid/fuzz/Cargo.lockis stale at candid 0.10.34, already onmaster. Nothing builds it with--locked, so it is harmless, but all four lockfiles should move together as a release-checklist step.🤖 Generated with Claude Code