server: allow the permission level a client displays for itself to be set

[xRookieFight]

No description provided.

[schphe]

func (p *Player) SetPermissionLevel(level session.PermissionLevel) {

I believe this shouldn't be exposing the session package
that aside, I wonder if the naming is a bit misleading,
as it could be perceived as granting permission at first glance

[xRookieFight]

It's PermissionLevel on the official protocol docs, however I can rename it as ClientPermissionLevel or something if it is misleading.

[cjmustard]

@HashimTheArab @didntpot @RestartFU is this the best way to do this?

[cjmustard]

Should PermissionLevel be included in Data() as well? Since Config.Apply() now reads it back into the player, it seems like a level set with SetPermissionLevel() would be lost when the player data is saved/reloaded.

[cjmustard]

One other small thing I noticed: StartGame still always sends PlayerPermissions as PermissionLevelMember in server.go. Should that initial value use the configured permission level too, or is it expected to be corrected later by UpdateAbilities?

[xRookieFight]

@schphe - exposing session in the public API: moved the type out of session into a new server/player/permission package, matching the existing player/hud, player/input, player/skin pattern (small leaf packages that both player and session can import). It now reads p.SetPermissionLevel(permission.Operator()), and session only consumes it through Controllable.

On the naming: I kept PermissionLevel since that is what the protocol field is called, and the doc comment on permission.Level states explicitly that it only changes what the client displays and allows locally - cmd.Allower is still the only thing deciding whether a command may be run. Happy to rename it if you still find it misleading.

@cjmustard - Data(): good catch, it was missing. Added PermissionLevel: p.permission so a level set with SetPermissionLevel() survives a save/reload round trip.

@cjmustard - StartGame: it is now taken from the loaded player data in finaliseConn:

data.PlayerPermissions, _ = d.PermissionLevel.Permissions()

UpdateAbilities would have corrected it shortly after anyway, but sending the right value up front avoids the client briefly rendering itself as a member.