MSDropDown 3.5.2#64
Open
antoniobenedetti wants to merge 1 commit into
Open
Conversation
The current version of this plugin is outdated from 12th Aug, 2009. This one is from 10 Nov, 2012 https://github.com/marghoobsuleman/ms-Dropdown/tree/master/js/msdropdown
|
Is this tested to work with latest gpanel? |
Owner
|
I initially tried the latest and had issues with it which is why I didn't immediately update it. |
Contributor
Author
|
Um.. the dropdown menus are working, but i guess some additional tweaking will be needed. |
Owner
|
They work, as in they drop down, but all the images etc ceased to work. Will have to figure out why. |
Contributor
Author
|
From the changelog: css .arrow class is changed to .ddArrow (it was too common) |
Owner
|
hmm. Feel free to figure it out if you want, but I am not in a rush to update this js as I've never heard any complaints about it |
Contributor
Author
|
Yes, there is no good reason to rush this but updated scripts tend to work more efficiantly and are more secure (XSS wise). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of this plugin is outdated from 12th Aug, 2009. This one is from 10 Nov, 2012 https://github.com/marghoobsuleman/ms-Dropdown/tree/master/js/msdropdown