fix(fp): extend Sentry server CPE suppression to other ecosystems#8524
Open
chadlwilson wants to merge 2 commits into
Open
Conversation
Signed-off-by: Chad Wilson <[email protected]>
…ve-sentry-suppression
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates a hand-curated suppression to reduce false positives for Sentry Server CVEs by refining the notes and the suppression match patterns.
Changes:
- Expanded the suppression notes with additional issue context and an NVD query link.
- Modified the
packageUrlregex to broaden/adjust which ecosystems are affected by the suppression. - Adjusted the
cperegex to matchcpe:/a:sentry:sentrywith optional suffix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an extension of earlier PR #8058 to suppress for other ecosystems - excluding
docker,generic.There are hundreds of sentry packages across various ecossytems, from
maventocomposer,cargo,npm,rubygems,goandswift. The self-hosted server is Python (and typescript) based and used to be distributed on the previously excluded Python package, but is now distributed as docker images with pre-compiled Python: https://github.com/getsentry/sentry/blob/master/self-hosted/DockerfileThis is all a bit of a minefield, but it should be relatively safe to extend the suppression as suggested here, while still matching for folks against the self-hosted instance (even though we don't support discovering docker dependencies right now).
Related issues
Have test cases been added to cover the new functionality?
yes/no