Repository navigation
Revert Excon EOF error fingerprint updates - #16818
Open
v-abhishekbhaskar wants to merge 1 commit into
Open
v-abhishekbhaskar wants to merge 1 commit into
v-abhishekbhaskar wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The production Sentry grouping change requires human verification of the unavailable dependabot-api companion change and deployment order to avoid regrouping EOF errors twice.
No open issues 🎉
What changed in this PR
Reverts the Excon EOF fingerprinting introduced in #16167, preparing for call-site grouping to move to dependabot-api. Errors without sentry_context no longer receive a fallback fingerprint; existing custom fingerprints remain unchanged.
Changes:
- Removes the EOF fingerprint helper and its dedicated specs.
- Removes fallback fingerprint generation from five updater error-reporting paths.
- Updates regression specs to assert that EOF error reports omit the fingerprint key.
Deployment should occur together with, or just before, the dependabot-api rollup change to avoid regrouping EOF errors twice.
| File | Description |
|---|---|
updater/spec/dependabot/updater/error_handler_spec.rb |
Expects EOF error reports without a fingerprint. |
updater/spec/dependabot/update_graph_command_spec.rb |
Checks duplicate graph error reports omit the fingerprint. |
updater/spec/dependabot/update_files_command_spec.rb |
Checks duplicate file-update error reports omit the fingerprint. |
updater/spec/dependabot/service_spec.rb |
Verifies EOF socket errors receive no fingerprint. |
updater/spec/dependabot/sentry/error_fingerprint_spec.rb |
Deletes specs for the removed helper. |
updater/lib/dependabot/updater/error_handler.rb |
Returns nil when no existing fingerprint is available. |
updater/lib/dependabot/update_graph_command.rb |
Removes fallback fingerprint generation. |
updater/lib/dependabot/update_files_command.rb |
Uses only fingerprints supplied by sentry_context. |
updater/lib/dependabot/service.rb |
Removes the helper dependency and fallback fingerprint. |
updater/lib/dependabot/sentry/error_fingerprint.rb |
Deletes the EOF call-site fingerprint helper. |
updater/lib/dependabot/base_command.rb |
Removes fallback fingerprinting for unknown errors. |
Review effort: Balanced
v-robaiken
approved these changes
Nov 4, 2026
Removes Dependabot::Sentry::ErrorFingerprint (added in #16167). Errors without sentry_context are once again reported with no fingerprint. Fingerprints are limited to CLI command templates; call-site grouping will come from the dependabot-api rollup instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d452abb-cad5-4768-92e3-632ae273a163
v-abhishekbhaskar
force-pushed
the
abhishekbhaskar/revert-excon-eof-fingerprint
branch
from
November 6, 2026 19:32
699b82e to
6c9cff2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This removes the Excon EOF fingerprint added in #16167 (
Dependabot::Sentry::ErrorFingerprint). Errors withoutsentry_contextare now reported with no fingerprint again. This applies inService#capture_exception,BaseCommand#handle_unknown_error,UpdateFilesCommand#handle_parser_error,UpdateGraphCommandandUpdater::ErrorHandler.Why: we're making Sentry grouping consistent. A fingerprint should only hold a CLI command template. The EOF fingerprint also included the package manager and the calling method, which doesn't fit that rule. Splitting errors by where they were raised will move to the dependabot-api rollup, which will use the top Dependabot backtrace frames.
Anything you want to highlight for special attention from reviewers?
fingerprintkey is absent, because empty values are dropped fromerror_details.error_handler_spec.How will you know you've accomplished your goal?
record_update_job_unknown_errorwithout a fingerprint (covered inservice_spec,update_files_command_spec,update_graph_command_specanderror_handler_spec).bundle exec rubocopon the changed files: passed, no offenses.bundle exec srb tc: passed.bundle exec rspecon the 4 updater specs (run on the host): 138 examples, 2 failures. The 2 failures (update_files_command_spec.rb:56,update_graph_command_spec.rb:59) also fail on the host without this change. I haven't run the specs in Docker yet.Checklist