fix(ext/webidl): implement async_sequence for ReadableStream.from - #35976
Merged
Conversation
crowlKats
self-requested a review
July 11, 2026 17:13
petamoriken
commented
Jul 11, 2026
| "from.any.html": { | ||
| "expectedFailures": [ | ||
| "ReadableStream.from ignores a null @@asyncIterator", | ||
| "ReadableStream.from accepts a string" |
Contributor
Author
There was a problem hiding this comment.
WPT for ReadableStream.from accepting a string will be updated to throw a TypeError in web-platform-tests/wpt#59594
Member
There was a problem hiding this comment.
Could you bump the WPT submodule so this test is included?
Replace the ad-hoc async iterable converter with Web IDL async_sequence conversion (GetMethod, Object-only, CreateAsyncFromSyncIterator) and wire ReadableStream.from to async_sequence<any>, per whatwg/streams#1372. Closes denoland#35777
petamoriken
force-pushed
the
fix/async-sequence
branch
from
July 19, 2026 14:11
f089f7e to
779c6a1
Compare
petamoriken
commented
Jul 19, 2026
Comment on lines
-465
to
+466
| interface ConvertedAsyncIterable<V, T> extends AsyncIterableIterator<T> { | ||
| interface ConvertedAsyncSequence<V, T> extends AsyncIterable<T> { |
Contributor
Author
There was a problem hiding this comment.
nits: ConvertedAsyncSequence is an Iterable but not an Iterator, as it does not have a next method
petamoriken
commented
Jul 21, 2026
Comment on lines
-118
to
+123
| "from.any.html": { | ||
| "expectedFailures": [ | ||
| "ReadableStream.from ignores a null @@asyncIterator", | ||
| "ReadableStream.from accepts a string" | ||
| ] | ||
| }, | ||
| "from.any.worker.html": { | ||
| "expectedFailures": [ | ||
| "ReadableStream.from ignores a null @@asyncIterator", | ||
| "ReadableStream.from accepts a string" | ||
| ] | ||
| }, | ||
| "from.any.html": true, | ||
| "from.any.worker.html": true, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35777
Closes #35611
Closes #30020
Generated with assistance from Grok Build