[LOW] Pin workflow actions to immutable commits - #998
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
The build, test, and daily workflows currently execute
actions/checkout@v5andruby/setup-ruby@v1through mutable references. A moved or compromised reference would let changed third-party code run in repository workflows. The manually dispatched build job also exposes Docker Hub publishing credentials to its steps.This change pins:
actions/checkouttofbc6f3992d24b796d5a048ff273f7fcc4a7b6c09(v5at review time; verified GitHub commit)ruby/setup-rubyto95ef2b042f9d7a56d8268cba8559e2842e2ad01b(v1at review time)Both exact revisions resolve and contain their expected
action.ymlmanifests.Verification
.github/dependabot.ymlparse as YAML.uses:reference is now a full 40-character commit SHA.git diff --checkpasses.No runtime source or dependency version changed, so the debugger test suite was not rerun for this workflow-only patch.
Breaking change
None.
Limitations
This patch covers third-party GitHub Actions. It does not make mutable container images or downloaded external build artifacts reproducible; those are separate infrastructure concerns and are not used to publish the gem in these workflows.