Update tutorial 32 to use the langdetect-haystack integration#466
Draft
julian-risch wants to merge 1 commit into
Draft
Update tutorial 32 to use the langdetect-haystack integration#466julian-risch wants to merge 1 commit into
julian-risch wants to merge 1 commit into
Conversation
DocumentLanguageClassifier and TextLanguageRouter moved from Haystack core to the langdetect-haystack package. Update the install command and imports, and refresh the notebook outputs from an end-to-end run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates tutorial 32 ("Classifying Documents & Queries by Language") to use the new
langdetect-haystackintegration package, sinceDocumentLanguageClassifierandTextLanguageRouterhave moved out of Haystack core.Changes
pip install langdetect→pip install langdetect-haystackfrom haystack.components.classifiers import DocumentLanguageClassifier→from haystack_integrations.components.classifiers.langdetect import DocumentLanguageClassifierfrom haystack.components.routers import TextLanguageRouter→from haystack_integrations.components.routers.langdetect import TextLanguageRouterHow I tested it
Ran the full notebook end-to-end against the
langdetect-haystackpackage (installed from the integration branch) with a realOPENAI_API_KEY:unmatched)Merge order
CI executes the notebook, and
pip install langdetect-haystackwill only succeed once the package is published to PyPI. This depends on the integration PR (deepset-ai/haystack-core-integrations#3457) being merged andintegrations/langdetect-v1.0.0released. Part of https://github.com/deepset-ai/haystack-private/issues/373.🤖 Generated with Claude Code