Refactor MD setup for pre-parallel cleanup#7410
Closed
Audrey-777 wants to merge 5 commits into
Closed
Conversation
Collaborator
|
Great work. Feel free to proceed with your planned optimizations. One reminder: MD simulations consume significant memory for large systems, so try to minimize array usage. In the final testing phase, please use systems with a larger number of atoms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs a scoped MD code refactor in preparation for future parallel optimization. It does not intend to change
functionality, numerical behavior, or performance.
Changes include:
std::unique_ptrownership.Validation
Built production target successfully:
cmake -S . -B build-prod -DBUILD_TESTING=OFF -DENABLE_MPI=OFF -DENABLE_LCAO=OFF -DUSE_ELPA=OFFcmake --build build-prod -j2Ran targeted MD tests successfully:
ctest --test-dir build-mpi-test -R 'MODULE_MD' --output-on-failureAll targeted
MODULE_MDtests passed.