Skip to content

Implement formatting of GML responses - #225

Open
julianzz98 wants to merge 2 commits into
deegree:mainfrom
lat-lon:fix/gmlResponseFormatting-1857
Open

julianzz98 wants to merge 2 commits into
deegree:mainfrom
lat-lon:fix/gmlResponseFormatting-1857

Conversation

@julianzz98

@julianzz98 julianzz98 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Previously, GML responses were written on a single line, making the output difficult to read and potentially causing problems for software with line-length limits.

This PR uses the existing IndentingXMLStreamWriter to add line breaks and indentation for both single-item and collection responses. Individual text values, such as long coordinate lists, may still produce long lines.

The change was tested successfully locally.

Info: Created under supervision using Codex from OpenAI, GTP-6 Astra.

@julianzz98
julianzz98 requested a review from tfr42 October 16, 2026 13:25
@julianzz98 julianzz98 added the enhancement Improvement of existing feature or function label Oct 16, 2026
@julianzz98

Copy link
Copy Markdown
Contributor Author

In the TMC meeting on the 28.10.2026, the change proposed in this PR was considered a "breaking change", since it cannot be ruled out that other users may depend on this behavior.

The new commit 5171720 makes GML response formatting optional through the tunable deegree.oaf.gml.response.format.enabled.

The default is false, so responses keep their previous single-line format. To enable line breaks and indentation for both single items and collections, set:

-Ddeegree.oaf.gml.response.format.enabled=true

The setting is documented, and tests cover the default behavior as well as explicitly enabling and disabling formatting. The tunable was also tested successfully on a local setup.

Info: Created under supervision using Codex from OpenAI, GTP-6.1 Sol.

@julianzz98
julianzz98 force-pushed the fix/gmlResponseFormatting-1857 branch from 5171720 to 7795390 Compare November 5, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of existing feature or function

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant