Skip to content

Allow faraday client configuration #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srook wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

Allow faraday client configuration #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/fcm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ class FCM
INSTANCE_ID_API = "https://iid.googleapis.com"
TOPIC_REGEX = /[a-zA-Z0-9\-_.~%]+/

def initialize(json_key_path = "", project_name = "", http_options = {})
def initialize(json_key_path = "", project_name = "", http_options = {}, faraday_configurer = nil)

@hound hound Bot Apr 14, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [100/80]

@json_key_path = json_key_path
@project_name = project_name
@http_options = http_options
@faraday_configurer = faraday_configurer
end

# See https://firebase.google.com/docs/cloud-messaging/send-message
Expand Down Expand Up @@ -202,6 +203,7 @@ def for_uri(uri, extra_headers = {})
extra_headers.each do |key, value|
faraday.headers[key] = value
end
@faraday_configurer.call(faraday) if @faraday_configurer

@hound hound Bot Apr 14, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

@erimicel erimicel May 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have: We can probably move @faraday_configurer&.call(faraday) before faraday.adapter Faraday.default_adapter so users can add request middleware (e.g. faraday.request :retry) without confusing with ordering issues

end
yield connection
end
Expand Down
11 changes: 11 additions & 0 deletions spec/fcm_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@
end
end

describe 'faraday configurer' do
let(:configurer) { ->(faraday) { } }
let(:client) { FCM.new(json_key_path, '', {}, configurer) }

it 'should be called when initializing faraday client' do
expect(configurer).to receive(:call).with(Faraday::Connection)

client.__send__(:for_uri, '') {}
end
end

describe "#send_v1 or #send_notification_v1" do
let(:client) { FCM.new(json_key_path, project_name) }

Expand Down