Repository navigation
Gate uv.lock against pyproject.toml, and document the uv install path - #5
Merged
Merged
Conversation
Document that both `pyproject.toml` and `uv.lock` are actively supported and must stay in sync. This adds guidance on `uv lock --check`, explains the CI lockfile gate, and clarifies that `uv sync --frozen --extra dev` is required to install the full contributor toolchain.
uv.lock is committed and kept current, but nothing referenced it: CI and the Dockerfile both install with pip, no doc mentioned uv, and .roborev.toml excludes the file from adversarial review. That combination let it rot once already — 4b7a29f found it pinning a removed dependency and missing nbclient/ipykernel, which would have left notebook verification with no Jupyter kernel. Rather than keep a maintained-but-invisible artifact, commit to it: - New blocking `lockfile` job running `uv lock --check`. Blocking for the same reason `ruff check` is: it passes today, so keeping it passing costs nothing and there is no backlog to grandfather. Its own job rather than a step in `test`, since the lock does not vary by Python version and the check needs no project install. - README documents `uv sync --frozen --extra dev` as a supported alternative to pip. The `--extra dev` is load-bearing: the dev toolchain lives in [project.optional-dependencies], which uv does not install by default, while [dependency-groups] dev holds only respx. Plain `uv sync --frozen` therefore yields a runnable app with no pytest, ruff or mypy — verified against a throwaway environment. - CONTRIBUTING lists the new gate, and notes that [tool.*] edits do not invalidate the lock. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jqnatividad
force-pushed
the
uv-lockfile-gate
branch
from
September 15, 2026 12:11
7abdf27 to
06aa164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto
mainnow that #4 has merged — this PR is down to its own two commits and fourfiles.
The problem
uv.lockis committed and kept current, but nothing referenced it: CI and the Dockerfile bothinstall with pip, no doc mentioned uv, and
.roborev.tomlexcludes the file from adversarialreview. A maintained artifact that nothing watches — and it rotted once already. 4b7a29f found it
pinning a removed dependency and missing
nbclient/ipykernel, which would have left notebookverification with no Jupyter kernel. The symptom would have surfaced far from the cause.
The fix — commit to it rather than leave it invisible
lockfileCI job runninguv lock --check. Blocking for the same reasonruff checkis: it passes today, so keeping it passing costs nothing and there's no backlog tograndfather. Its own job rather than a step in
test, since the lock doesn't vary by Pythonversion (the matrix would check it twice) and the check needs no project install — about 8s in
practice.
uv sync --frozen --extra devas a supported alternative to pip, so thelockfile has acknowledged users.
[tool.*]edits don't invalidate the lock.--extra devis load-bearingThe dev toolchain lives in
[project.optional-dependencies], which uv does not install bydefault, while
[dependency-groups] devholds onlyrespx. Verified against a throwawayenvironment:
uv sync --frozenuv sync --frozen --extra devpip install -e ".[dev]"Documenting the bare command would have handed contributors a working app and no way to run the
suite.
Verification
uv lock --checkpasses at this branch's tip, so this PR's own CI run exercises thelockfilejob it adds — the gate self-tests before it ever guards anything.
🤖 Generated with Claude Code