Replace __cpuid_check for AVX512 with compiler builtin cpu features#655
Open
Replace __cpuid_check for AVX512 with compiler builtin cpu features#655
Conversation
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
Replaces manual CPUID bit parsing in jvector_simd_check.c with __builtin_cpu_supports and adds __builtin_cpu_init(). This corrects missing XSAVE runtime checks, preventing #UD exceptions on systems where 512‑bit register state saves are disabled.
c2bcf57 to
0f19393
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #629.
This pull request simplifies AVX-512 feature detection logic in the jvector_simd_check.c file by replacing manual CPUID bit checks with built-in compiler functions (available only on gcc and llvm compilers). The earlier code was missing XSAVE support at runtime. On VMs where 512‑bit register state saving is disabled, this can result in #UD faults when executing AVX‑512 instructions.
CPU feature detection improvements:
Added a call to __builtin_cpu_init() to ensure proper initialization before feature checks.
check_compatibilitytocheck_avx512_compatibility./proc/cpuinfo.