Skip to content

fix: remove version ID from Create Model screen #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrmaloof merged 3 commits into from
Apr 28, 2026
Merged

fix: remove version ID from Create Model screen #264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccc0fef
fix: remove version ID from create model screen
mrmaloof Apr 17, 2026
38dfadf
refactor: formatter
mrmaloof Apr 17, 2026
c245aa1
Merge branch 'develop' into fix/remove_version_number
mrmaloof Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 6 additions & 26 deletions resources/js/Pages/CreateModel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export default function CreateModel() {
url: '/create-model',
data: {
name: event.target.elements.model_name.value,
vers_id: event.target.elements.vers_id.value,
valid: validBool,
schema_configs: schemaConfig,
},
Expand All @@ -54,7 +53,7 @@ export default function CreateModel() {
<AppLayout
title="Create Model"
renderHeader={() => (
<h2 className="text-xl font-semibold leading-tight text-gray-800">
<h2 className="text-xl leading-tight font-semibold text-gray-800">
Create Model
</h2>
)}
Expand All @@ -69,14 +68,14 @@ export default function CreateModel() {
minorTitle="Create Model"
></HeaderLabel>
<form
className="w-full max-w-full pl-36 pr-36 pt-24"
className="w-full max-w-full pt-24 pr-36 pl-36"
onSubmit={handleSubmit}
>
<div id="form_contents" className="flex flex-col gap-y-6">
<div className="flex w-full flex-row gap-x-6">
<div className="flex w-full flex-col">
<label
className="mb-2 block text-xs font-bold uppercase tracking-wide text-gray-700"
className="mb-2 block text-xs font-bold tracking-wide text-gray-700 uppercase"
id="model_name"
>
Model Name
Expand All @@ -90,25 +89,6 @@ export default function CreateModel() {
<p className="text-xs italic text-red-500">Required field.</p>
</div>
</div>
<div className="flex w-1/2 flex-col">
<label
className="mb-2 block text-xs font-bold uppercase tracking-wide text-gray-700"
id="vers_id"
>
Version ID
</label>
<input
name="vers_id"
className="mb-3 block w-full appearance-none rounded border border-gray-200 bg-gray-200 px-4 py-3 leading-tight text-gray-700 focus:border-gray-500 focus:bg-white focus:outline-none"
type="number"
min="0"
max="10"
defaultValue="1"
></input>
<p className="text-xs italic text-gray-600">
Version ID of the model. Use one (1) for initial version.
</p>
</div>
<div className="flex w-1/2 flex-row items-center gap-x-3">
<input
type="radio"
Expand All @@ -127,7 +107,7 @@ export default function CreateModel() {
<legend className="text-base font-semibold text-gray-900">
Batch schema configs accepted by this model
</legend>
<div className="mt-4 divide-y divide-gray-200 border-b border-t border-gray-200">
<div className="mt-4 divide-y divide-gray-200 border-t border-b border-gray-200">
{schemas.map((schem, idx) => (
<div key={idx} className="flex gap-3">
<div className="min-w-0 flex-1 text-sm/6">
Expand All @@ -140,7 +120,7 @@ export default function CreateModel() {
/>
<label
htmlFor={`${schem.name}`}
className="m-2 select-none font-medium text-gray-900"
className="m-2 font-medium text-gray-900 select-none"
>
{schem.name}
</label>
Expand Down Expand Up @@ -191,7 +171,7 @@ export default function CreateModel() {
</button>
</div>
</form>
<div id="result_area" className="flex pb-24 pt-12"></div>
<div id="result_area" className="flex pt-12 pb-24"></div>
</div>
</AppLayout>
);
Expand Down