Merged
Conversation
…allet_identity configuration
ffarall
approved these changes
Apr 15, 2025
Contributor
|
There seems to be a problem in the build of the node in the CI. But building locally works, and from the look of the logs, it seems like it's something related to the caching we're doing in the CI. Also, please if you can highlight in the description of the PR the changes that you think are most relevant to us in this new stable release, much appreciated! |
gonzamontiel
approved these changes
Apr 16, 2025
Contributor
gonzamontiel
left a comment
There was a problem hiding this comment.
I see some unimplemented configs but I assume we don't really need them (one for handling slashes in pallet_balances and the other one in pallet_sudo).
For me, compiling and running rust tests works fine locally, LGTM
stiiifff
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update polkadot-sdk from
stable2409tostable2412.Changelog:
TransactionExtensionas a replacement forSignedExtensionparitytech/polkadot-sdk#3685SendTransactionTypeswithCreateTransactionBaseCreateInherentfor RuntimeUncheckedExtrinsic::new_unsignedwithUncheckedExtrinsic::new_bareExtensionsWeightInfotype toframe_system::ConfigFullPoolwithTransactionPoolHandlesp_runtime::RuntimeStringand replace withCow<'static, str>orStringdepending on use case paritytech/polkadot-sdk#5693Stringinstead of deprecatedRuntimeStringin the runtimeRuntimeVerisontype and usesystem_versionto derive extrinsics rootStateVersioninstead ofV0paritytech/polkadot-sdk#4257state_versionwithsystem_versionGood to know