Skip to content

[TPC-DS] Schema mismatch vs TPC spec #437

Closed

Description

@mwc360

Some TPCDS column names do not match the TPC spec: https://www.tpc.org/TPC_Documents_Current_Versions/pdf/[TPC-DS_v4.0.0.pdf](https://www.tpc.org/TPC_Documents_Current_Versions/pdf/TPC-DS_v4.0.0.pdf)

The following deviate:

  • cr_return_amount_inc_tax instead of cr_return_amt_inc_tax
  • ib_income_band_id instead of ib_income_band_sk
  • r_reason_description instead of r_reason_desc
  • s_tax_precentage instead s_tax_percentage correction
  • wr_store_credit instead of wr_account_credit

Java/C implementations had these typos, wouldn't it be better to adhere to the official TPC spec?

In LakeBench we made a strategic decision to adhere to spec so I'm currently evaluating whether we should intentionally adopt the typos just so that we can leverage this amazing project. We previously did not as the DuckDB generator did follow the spec without typos and this is what we elected to use for data generation.

Activity

  1. self-assigned this
    on Sep 8, 2026
  2. kevinjqliu commented on Sep 8, 2026

    @kevinjqliu
    Collaborator

    btw upstream reference microsoft/LakeBench#96

    I was talking with @mwc360 offline about using this project in LakeBench to generate tpch/tpcds data 😄

  3. kevinjqliu commented on Sep 8, 2026

    @kevinjqliu
    Collaborator

    This is a bug. I double checked with Trino. It uses the right-side

    • cr_return_amt_inc_tax
    • ib_income_band_sk
    • r_reason_desc
    • wr_account_credit

    s_tax_precentage vs s_tax_percentage is a different problem. The C impl itself misspelled the name 😄

    I also realized that our conformance check only verifies the data and not the column name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions