Add data-model-uml repo as git submodule of connector-codegen#32
Open
jgaehring wants to merge 6 commits into
Open
Add data-model-uml repo as git submodule of connector-codegen#32jgaehring wants to merge 6 commits into
data-model-uml repo as git submodule of connector-codegen#32jgaehring wants to merge 6 commits into
Conversation
In anticipation of adding the data-model-uml repo as a submodule.
Submodule data-model-uml 7fec056..621e823: > Fix Order:soldBy semantic mapping and add the property to supported.md > Add soldBy and update URI references > Add variant in Changelog and supported > Add DefinedProduct:isVariantOf > Add DefinedProduct:hasVariant > Add image to DefinedProduct > Fix PlannedTransformation property > Allow multiple consumption and production flows > Add Semantic stereotype to IFlow and IPlannedTransformation > Add Semantic stereotype to class Flow > Fix missing Semantic stereotype on ISocialMedia and IPhoneNumber interfaces (datafoodconsortium#13) > Fix duplicated SocialMedia getUrl method > Merge branch 'transformation-loop' into next > Add hasFulfilmentStatus, hasOrderStatus and hasPaymentStatus to Order > Add latitude, longitude and region to Address > Add logo to Agent
lecoqlibre
approved these changes
Jun 10, 2025
lecoqlibre
left a comment
lecoqlibre
left a comment
Member
There was a problem hiding this comment.
Should rather be merged in branch v1.3.0 like agreed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes updated documentation and pegs the code generation to datafoodconsortium/data-model-uml@732bc8e (v3.0.0).
It resolves #30.
I've rebased this on top of #29, which incorporates the
variantproperties and TypeScriptalpha-10release, but it does not incorporate the TypeSciprt Observer andalpha.11release. See my notes on #31, which I converted back to a draft since it does not yet include the Ruby or PHP versions of the Observer. Sorry, I forgot about this earlier today when we met.I also feel like we may as well bundle these submodule commits together with the addition of the variant properties and release them as v1.2.0, since they're both ready to go and directly related to changes in
data-model-uml, whereas the Observer work is not 100% complete and seems completely unrelated to the UML model. I have a branch v1.2.0 with an extra commit that would bump the version in CHANGELOG, too; if you want to go ahead with that, @lecoqlibre & @RaggedStaff, I could open a separate PR or push that commit onto this PR in a jiffy. Of course, I'm also happy to reopen #31, or split this out so it can be merged later as v1.3.0 or later, or whatever seems best to you all.