Skip to content

Forward cache bypass header from website to Mixer#6440

Open
rohitkumarbhagat wants to merge 3 commits into
datacommonsorg:masterfrom
rohitkumarbhagat:fwd-skip-cache
Open

Forward cache bypass header from website to Mixer#6440
rohitkumarbhagat wants to merge 3 commits into
datacommonsorg:masterfrom
rohitkumarbhagat:fwd-skip-cache

Conversation

@rohitkumarbhagat

@rohitkumarbhagat rohitkumarbhagat commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Forward a canonical X-Skip-Cache: true header to Mixer for valid cache-bypass requests
  • Ensure cache bypass requests skip both website and Mixer caches.
  • Add tests covering valid and invalid header values.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces functionality to propagate cache bypass requests from the website layer to the Mixer service. By forwarding the 'X-Skip-Cache' header, the system ensures consistent cache skipping behavior across the architecture, improving cache invalidation control for specific requests.

Highlights

  • Cache Bypass Header Forwarding: Implemented logic to forward the 'X-Skip-Cache' header from website requests to the Mixer service.
  • Header Normalization: Ensured that the 'X-Skip-Cache' header value is normalized to lowercase 'true' when forwarded.
  • Testing: Added unit tests to verify that valid 'X-Skip-Cache' headers are correctly forwarded and invalid values are ignored.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the get_basic_request_headers function to forward the X-Skip-Cache header to the mixer service when should_skip_cache() evaluates to true. It also adds corresponding unit tests to verify this behavior. The feedback suggests parameterizing the new unit tests to more comprehensively cover various valid and invalid header values.

Comment thread server/tests/services/datacommons_test.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rohitkumarbhagat rohitkumarbhagat requested a review from vish-cs July 10, 2026 09:47
@rohitkumarbhagat rohitkumarbhagat enabled auto-merge (squash) July 10, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants