Skip to content

Automated Integration Test Goldens Update from CI#6438

Merged
nick-nlb merged 2 commits into
masterfrom
nl-golden-update-339218b8-b632-49d1-a342-19110dc1adad
Jul 10, 2026
Merged

Automated Integration Test Goldens Update from CI#6438
nick-nlb merged 2 commits into
masterfrom
nl-golden-update-339218b8-b632-49d1-a342-19110dc1adad

Conversation

@datacommons-robot-author

Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and juliawu and removed request for a team July 9, 2026 18:26
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated updates to integration test golden files generated by Cloud Build. These changes ensure that the test expectations remain aligned with the latest data processing outputs, preventing regression failures in the CI pipeline.

Highlights

  • Golden File Updates: Updated various integration test golden files to reflect recent data changes in chart configurations.
  • Configuration Refinement: Adjusted statistical variable keys and facet identifiers across multiple test datasets to ensure consistency with current data exports.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several integration test chart configurations, including removing a hate crime variable, swapping male and female labor force variables, updating facet IDs for female population metrics, and adding a quantity classification to a state PhD ranking query. Regarding the feedback, the addition of a quantity classification with a minimum float value (2.2250738585072014e-308) to the stateswithhighestphds ranking query appears to be a regression in the quantity detection logic or LLM parser and should be investigated.

Comment on lines +4 to +13
{
"quantity": {
"idx": 0,
"qval": {
"cmp": "GE",
"val": 2.2250738585072014e-308
}
},
"type": 3
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The query stateswithhighestphds is a ranking query and should not trigger a quantity classification. The addition of a quantity classification with val: 2.2250738585072014e-308 (which is sys.float_info.min) suggests a regression or bug in the quantity detection logic or LLM parser. Please investigate why this query is being classified as a quantity query with a minimum float value.

@nick-nlb nick-nlb merged commit a228ba7 into master Jul 10, 2026
18 checks passed
@nick-nlb nick-nlb deleted the nl-golden-update-339218b8-b632-49d1-a342-19110dc1adad branch July 10, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants