Default to SVG name for display for non-base DC

[n-h-diaz]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces a new helper function isCustomHierarchy to identify SVGs from non-base Data Commons instances and integrates it into getSpecializedEntity alongside an empty check on childName. The reviewer suggests renaming isCustomHierarchy to isNonBaseDCHierarchy to prevent confusion with existing custom SVGs that start with "dc/", and adding an empty string check to the helper for robustness.

[gemini-code-assist]

The name isCustomHierarchy is potentially misleading because "Custom" is already used in the codebase (e.g., CustomSVGPrefix = "dc/g/Custom_") to refer to local custom SVGs, which do start with dc/. Since this function specifically checks for SVGs from a non-base Data Commons instance (which do not start with dc/), renaming it to isNonBaseDCHierarchy or isExternalHierarchy would be much clearer and prevent future confusion. Additionally, adding a check for an empty string makes the helper more robust.

Suggested change

	// isCustomHierarchy checks if the SVG is part of a non-base DC.
	func isCustomHierarchy(svg string) bool {
	return !strings.HasPrefix(svg, "dc/")
	}
	// isNonBaseDCHierarchy checks if the SVG is part of a non-base DC.
	func isNonBaseDCHierarchy(svg string) bool {
	return svg != "" && !strings.HasPrefix(svg, "dc/")
	}

References

1. Ensure that function docstrings accurately reflect the function's signature and return values.

[gemini-code-assist]

Update the call to use the renamed isNonBaseDCHierarchy function for clarity.

Suggested change

	func getSpecializedEntity(parent, child, childName string) string {
	if !strings.Contains(child, "_") || isCuratedHierarchy(child) { // Child is likely curated.
	if childName != "" && (!strings.Contains(child, "_") || isCuratedHierarchy(child) || isCustomHierarchy(child)) { // Child is likely curated.
	return childName
	}
	func getSpecializedEntity(parent, child, childName string) string {
	if childName != "" && (!strings.Contains(child, "_") || isCuratedHierarchy(child) || isNonBaseDCHierarchy(child)) { // Child is likely curated.
	return childName
	}