point mixer-api-key to dc-api-key #1949
Open
yiyche wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the value of the MixerAPIKeyID constant to 'dc-api-key' in internal/util/util.go. The reviewer suggests renaming the constant to DCAPIKeyID and updating its associated comment and references to maintain consistency and avoid confusion.
| MapsAPIKeyID = "maps-api-key" | ||
| // Mixer API key | ||
| MixerAPIKeyID = "mixer-api-key" | ||
| MixerAPIKeyID = "dc-api-key" |
Contributor
There was a problem hiding this comment.
Since this constant now points to "dc-api-key", keeping the name MixerAPIKeyID is misleading and can cause confusion. Consider renaming the constant to DCAPIKeyID to accurately reflect its value.
Note that you will also need to update:
- The comment on line 65 to
// DC API key. - Its reference in
internal/server/server.go(line 138).
Suggested change
| MixerAPIKeyID = "dc-api-key" | |
| DCAPIKeyID = "dc-api-key" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in CDC they're pointed to the same thing. next step would be remove references to this in
website/build/cdc_services/run.shandwebsite/run_cdc_dev.sh.