feat: implement SDMX HTTP response support using google.api.HttpBody#1914
feat: implement SDMX HTTP response support using google.api.HttpBody#1914rohitkumarbhagat wants to merge 2 commits into
Conversation
…and add a query probe for debugging
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary query probe endpoint (V3SdmxQueryProbe) to validate SDMX query parsing through Envoy and ESPv2, along with comprehensive design and routing documentation. It adds the vendored google.api.HttpBody proto, implements the probe handler that parses raw query parameters from the x-envoy-original-path metadata, and includes corresponding unit tests. The review feedback suggests a security improvement to expand the list of redacted query parameter names in redactSDMXProbeValue to prevent accidental leakage of sensitive tokens or credentials in debug logs and responses.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| func redactSDMXProbeValue(name, value string) string { | ||
| switch strings.ToLower(name) { | ||
| case "key", "api_key", "api-key", "apikey", "access_token": | ||
| return "[REDACTED]" | ||
| default: | ||
| return value | ||
| } | ||
| } |
There was a problem hiding this comment.
To prevent accidental leakage of sensitive tokens or credentials in debug logs and responses, consider expanding the list of redacted query parameter names in redactSDMXProbeValue to include other common names such as "access-token", "token", "secret", "authorization", and "auth".
| func redactSDMXProbeValue(name, value string) string { | |
| switch strings.ToLower(name) { | |
| case "key", "api_key", "api-key", "apikey", "access_token": | |
| return "[REDACTED]" | |
| default: | |
| return value | |
| } | |
| } | |
| func redactSDMXProbeValue(name, value string) string { | |
| switch strings.ToLower(name) { | |
| case "key", "api_key", "api-key", "apikey", "access_token", "access-token", "token", "secret", "authorization", "auth": | |
| return "[REDACTED]" | |
| default: | |
| return value | |
| } | |
| } |
References
- Avoid logging entire request objects, such as SparqlRequest, as they may contain sensitive information or PII. Sanitize or mask data before logging.
…rameters and constraint formats
No description provided.