Skip to content

Data release: release-20260512#1891

Open
ajaits wants to merge 1 commit into
datacommonsorg:masterfrom
ajaits:release-20260512
Open

Data release: release-20260512#1891
ajaits wants to merge 1 commit into
datacommonsorg:masterfrom
ajaits:release-20260512

Conversation

@ajaits

@ajaits ajaits commented May 12, 2026

Copy link
Copy Markdown
Contributor

Mixer data release: release-20260512

@ajaits ajaits requested a review from hareesh-ms May 12, 2026 17:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a data refresh across several configuration and golden test files, including updates to BigTable table names, BigQuery versions, and statistical variable counts. Feedback was provided regarding the modification of several ranking test files where the data was set to null instead of an empty array []. This change could potentially cause runtime errors if the consuming logic expects an array structure.

"relatedChart": {}
}
] No newline at end of file
null No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting this test file to null instead of an empty array [] is likely to cause runtime errors if the consuming code expects an array. Please use [] to represent an empty list of rankings.

Suggested change
null
[]

"relatedChart": {}
}
] No newline at end of file
null No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting this test file to null instead of an empty array [] is likely to cause runtime errors if the consuming code expects an array. Please use [] to represent an empty list of rankings.

Suggested change
null
[]

"relatedChart": {}
}
] No newline at end of file
null No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting this test file to null instead of an empty array [] is likely to cause runtime errors if the consuming code expects an array. Please use [] to represent an empty list of rankings.

Suggested change
null
[]

"relatedChart": {}
}
] No newline at end of file
null No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting this test file to null instead of an empty array [] is likely to cause runtime errors if the consuming code expects an array. Please use [] to represent an empty list of rankings.

Suggested change
null
[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant