Skip to content

Add dedup logic during mcf merge#630

Merged
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:dedup
Jul 10, 2026
Merged

Add dedup logic during mcf merge#630
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:dedup

Conversation

@vish-cs

@vish-cs vish-cs commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity

Metric Results
Complexity 4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the graph node merging logic in PipelineUtils.java to improve deduplication and handle a special case for the typeOf property. Specifically, if a default Place type is present alongside other non-default types, the Place type is dropped. A corresponding unit test has been added to verify this behavior. The review feedback suggests a minor improvement to use Collection.removeIf for in-place list modification instead of Java Streams, which simplifies the code and avoids unnecessary overhead.

Comment thread pipeline/util/src/main/java/org/datacommons/ingestion/util/PipelineUtils.java Outdated
@vish-cs vish-cs merged commit 1eeb164 into datacommonsorg:master Jul 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants